New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Injection false positive with where_values_hash #942

Closed
JasonBarnabe opened this Issue Oct 4, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@JasonBarnabe
Contributor

JasonBarnabe commented Oct 4, 2016

Use of where_values_hash is causing a false positive in brakeman.

class CanadianGroup < Group
  has_many :products,
           -> { where(Product.canadian.where_values_hash) }
end

(Product.canadian here is a scope.)

@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Oct 12, 2016

Owner

Hi Jason,

Yes, I'll fix that up soon.

Owner

presidentbeef commented Oct 12, 2016

Hi Jason,

Yes, I'll fix that up soon.

presidentbeef added a commit that referenced this issue Oct 15, 2016

Repository owner locked and limited conversation to collaborators Mar 10, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.