New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize bin/brakeman #1076

Merged
merged 6 commits into from Aug 12, 2017

Conversation

Projects
None yet
2 participants
@presidentbeef
Owner

presidentbeef commented Aug 9, 2017

Move most of bin/brakeman into lib/brakeman/commandline.rb

  • Simplify bin/brakeman
  • Easier for people to extend if they want
  • Possible to test now!

@presidentbeef presidentbeef merged commit 74f14c2 into master Aug 12, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@presidentbeef presidentbeef deleted the command_line_module branch Aug 12, 2017

@@ -3,100 +3,6 @@
$:.unshift "#{File.expand_path(File.dirname(__FILE__))}/../lib"
require 'brakeman'
require 'brakeman/options'
require 'brakeman/version'

This comment has been minimized.

@zimbatm

zimbatm Aug 16, 2017

require 'brakeman/version' is missing now leading to a constant error

@zimbatm

zimbatm Aug 16, 2017

require 'brakeman/version' is missing now leading to a constant error

This comment has been minimized.

@presidentbeef

presidentbeef Aug 16, 2017

Owner

Thanks, fixed with #1079

@presidentbeef

presidentbeef Aug 16, 2017

Owner

Thanks, fixed with #1079

Repository owner locked and limited conversation to collaborators Sep 25, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.