New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require missing `brakeman/version` module #1079

Merged
merged 1 commit into from Aug 16, 2017

Conversation

Projects
None yet
2 participants
@gyndav
Contributor

gyndav commented Aug 16, 2017

Since v3.7.1, a regression was introduced in c204a92 causing cli call with option --ensure-latest to fail.

❯ bin/brakeman --ensure-latest --rails4
my_project/vendor/bundle/ruby/2.3.0/gems/brakeman-3.7.1/lib/brakeman.rb:315:in `ensure_latest': uninitialized constant Brakeman::Version (NameError)
	from my_project/vendor/bundle/ruby/2.3.0/gems/brakeman-3.7.1/lib/brakeman/commandline.rb:42:in `check_latest'
	from my_project/vendor/bundle/ruby/2.3.0/gems/brakeman-3.7.1/lib/brakeman/commandline.rb:34:in `run'
	from my_project/vendor/bundle/ruby/2.3.0/gems/brakeman-3.7.1/lib/brakeman/commandline.rb:20:in `start'
	from my_project/vendor/bundle/ruby/2.3.0/gems/brakeman-3.7.1/bin/brakeman:8:in `<top (required)>'
	from bin/brakeman:17:in `load'
	from bin/brakeman:17:in `<main>'
@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Aug 16, 2017

Owner

Awesome...completely screws up my plans for the 100th release. 😭

Owner

presidentbeef commented Aug 16, 2017

Awesome...completely screws up my plans for the 100th release. 😭

@presidentbeef presidentbeef merged commit e864970 into presidentbeef:master Aug 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gyndav

This comment has been minimized.

Show comment
Hide comment
@gyndav

gyndav Aug 16, 2017

Contributor

LMAO sorry 'bout that 😅

Contributor

gyndav commented Aug 16, 2017

LMAO sorry 'bout that 😅

@gyndav gyndav deleted the gyndav:fix-ensure-latest-option branch Aug 16, 2017

Repository owner locked and limited conversation to collaborators Sep 25, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.