New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use initializer when processing libs #1161

Merged
merged 2 commits into from Feb 17, 2018

Conversation

Projects
None yet
1 participant
@presidentbeef
Owner

presidentbeef commented Feb 17, 2018

Pull instance variable values from initialize when processing other methods in libraries.

Kind of like how we handle before_action in controllers.

presidentbeef added some commits Feb 17, 2018

Use ivars from `initialize` in libraries
when processing other methods in the library

@presidentbeef presidentbeef merged commit eb771bd into master Feb 17, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (80% threshold)
Details
codeclimate/total-coverage 94% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@presidentbeef presidentbeef deleted the use_initializer_when_processing_libs branch Feb 17, 2018

Repository owner locked and limited conversation to collaborators May 9, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.