New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --parser-timeout option #1194

Merged
merged 3 commits into from May 5, 2018

Conversation

Projects
None yet
1 participant
@presidentbeef
Owner

presidentbeef commented May 5, 2018

This sets the timeout used for parsing a single file.

The default is the same as RubyParser's current default: 10 seconds.

This PR also changes the error message when a timeout does occur to something useful.

presidentbeef added some commits May 5, 2018

Pass Tracker to FileParser for inline ERB
Not sure why this wasn't done before...laziness?

@presidentbeef presidentbeef merged commit 09d6636 into master May 5, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (90% threshold)
Details
codeclimate/total-coverage 94% (0.1% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@presidentbeef presidentbeef deleted the option_for_parser_timeout branch May 5, 2018

Repository owner locked and limited conversation to collaborators Jul 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.