New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow `symbolize_keys` to be called on params #1217

Merged
merged 1 commit into from May 25, 2018

Conversation

Projects
None yet
2 participants
@JacobEvelyn
Contributor

JacobEvelyn commented May 23, 2018

Fixes #1206

@presidentbeef presidentbeef merged commit f5af91a into presidentbeef:master May 25, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (90% threshold)
Details
codeclimate/total-coverage 94% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@presidentbeef

This comment has been minimized.

Owner

presidentbeef commented May 25, 2018

🆒 Thanks!

@JacobEvelyn JacobEvelyn deleted the JacobEvelyn:symbolic-gesture branch May 25, 2018

@JacobEvelyn

This comment has been minimized.

Contributor

JacobEvelyn commented May 29, 2018

Thanks for the quick merging of these two PRs, @presidentbeef! Selfishly, it would help us a lot if you could release a new gem version soon, but I'll let you determine when it makes the most sense for you. 😄

@presidentbeef

This comment has been minimized.

Owner

presidentbeef commented Jun 1, 2018

A release takes about a full day of work, so hard to say. Maybe very soon, schedule permitting.

That being said, master is pretty much always stable.

@JacobEvelyn

This comment has been minimized.

Contributor

JacobEvelyn commented Jun 4, 2018

Gotcha, thanks for the info!

Repository owner locked and limited conversation to collaborators Jul 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.