New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow string.shellescape and Shellwords.shelljoin in CheckExecute #1242

Merged
merged 1 commit into from Sep 6, 2018

Conversation

Projects
None yet
2 participants
@oggy
Copy link
Contributor

oggy commented Jul 13, 2018

No description provided.

@oggy oggy force-pushed the custora:shellescape branch from 1cc8475 to 482dca7 Jul 13, 2018

@presidentbeef

This comment has been minimized.

Copy link
Owner

presidentbeef commented Jul 20, 2018

Hi George,

Thanks for the PR!

For future reference, it's easier to add test code to the bottom of the file so you don't have to change the line numbers on a bunch of unrelated tests.

Typically I like to add tests that the warning was not found (assert_no_warning) to make it easier in the future if the false positives pop back up.

So I can merge this PR, please acknowledge that copyright for all contributions will be assigned to Synopsys, Inc. per our contribution guidelines. Thanks!

@presidentbeef presidentbeef merged commit 5cd82ae into presidentbeef:master Sep 6, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (90% threshold)
Details
codeclimate/total-coverage 94% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Repository owner locked and limited conversation to collaborators Oct 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.