New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more structured message construction #1259

Merged
merged 15 commits into from Sep 13, 2018
Merged
Diff settings

Always

Just for now

HTML report should use rel="noreferrer" correctly

not rel="no-referrer"
  • Loading branch information...
presidentbeef committed Sep 11, 2018
commit d3e487bfd1d080971af56f7658bf2c8888e4cdb2
@@ -74,7 +74,7 @@ def convert_warning warning, original
end

def with_link warning, message
"<a rel=\"no-referrer\" href=\"#{warning.link}\">#{message}</a>"
"<a rel=\"noreferrer\" href=\"#{warning.link}\">#{message}</a>"
end

def convert_template_warning warning, original
@@ -13,7 +13,7 @@ def test_html_sanity
assert report.is_a? String
assert report.match(/\A<!DOCTYPE HTML SYSTEM>.*<\/html>\z/m)
report.scan(/<a[^>]+>/).each do |a|
assert a.include?("no-referrer"), "#{a} does not include 'no-referrer'"
assert a.include?("noreferrer"), "#{a} does not include 'noreferrer'"
end
end

ProTip! Use n and p to navigate between commits in a pull request.