New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use default hash values in CallIndex #1271

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
1 participant
@presidentbeef
Copy link
Owner

presidentbeef commented Oct 10, 2018

Using default values causes a thread-safety issue when running checks in parallel (the default). If a key doesn't exist during a search, the hash can be updated when other threads are accessing it.

The error looks like: can't add a new key into hash during iteration

Do not use default hash values in CallIndex
It causes a thread-safety issue when running checks in parallel (the
default). If a key doesn't exist during a search, the hash can be
updated when other threads are accessing it.

@presidentbeef presidentbeef merged commit 9aa3558 into master Oct 12, 2018

3 of 5 checks passed

codeclimate 1 issue to fix
Details
codeclimate/diff-coverage 85% (90% threshold)
Details
ci/circleci Your tests passed on CircleCI!
Details
codeclimate/total-coverage 94% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@presidentbeef presidentbeef deleted the call_index_default_hash_value branch Oct 12, 2018

Repository owner locked and limited conversation to collaborators Feb 4, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.