New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade version upper boundary of slim to v4.0.1 #1285

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
2 participants
@Jakenberg
Copy link
Contributor

Jakenberg commented Dec 4, 2018

This is in regards to issue #1284.

@Jakenberg Jakenberg referenced this pull request Dec 4, 2018

Closed

Slim v4.0 parser failure #1284

@presidentbeef

This comment has been minimized.

Copy link
Owner

presidentbeef commented Dec 6, 2018

@Jakenberg Thanks for looking into this.

Can you add an example of the new syntax to a Slim template in https://github.com/presidentbeef/brakeman/tree/master/test/apps/rails5.2 for testing? Thanks!

@Jakenberg Jakenberg force-pushed the Jakenberg:master branch from 4e6c70e to 98d9ace Dec 7, 2018

@Jakenberg

This comment has been minimized.

Copy link
Contributor Author

Jakenberg commented Dec 7, 2018

No problem. Added what I think you mean. Let me know if it should be different 👍

@Jakenberg Jakenberg force-pushed the Jakenberg:master branch from 98d9ace to 4b80cfe Dec 7, 2018

@presidentbeef

This comment has been minimized.

Copy link
Owner

presidentbeef commented Dec 10, 2018

Okay, asking you to add the test was a mistake since Ruby 1.9.3 is not supported by Slim 4.0 :(

Do you mind backing that change out and then I'll merge? Thanks again!

@Jakenberg Jakenberg force-pushed the Jakenberg:master branch from 4b80cfe to 5bcccce Dec 10, 2018

@Jakenberg Jakenberg force-pushed the Jakenberg:master branch from 5bcccce to 0a3483c Dec 10, 2018

@Jakenberg

This comment has been minimized.

Copy link
Contributor Author

Jakenberg commented Dec 10, 2018

Bummer :( Updated

@presidentbeef presidentbeef merged commit f5fa669 into presidentbeef:master Dec 10, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@presidentbeef

This comment has been minimized.

Copy link
Owner

presidentbeef commented Dec 10, 2018

Thanks!

Repository owner locked and limited conversation to collaborators Feb 4, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.