New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade RubyParser to 3.12 #1286

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
2 participants
@presidentbeef
Copy link
Owner

presidentbeef commented Dec 4, 2018

Also, minor versions are not as scary now (especially with the dependency vendoring), so be more liberal there.

@djpate

This comment has been minimized.

Copy link

djpate commented Dec 5, 2018

👍 I need this as well

@presidentbeef

This comment has been minimized.

Copy link
Owner Author

presidentbeef commented Dec 10, 2018

Just a note that there is a (probably rare) regression introduced by 3.12.0: seattlerb/ruby_parser#272

@presidentbeef presidentbeef merged commit 1bff87f into master Dec 10, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (90% threshold)
Details
codeclimate/total-coverage 94% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@presidentbeef presidentbeef deleted the upgrade_to_ruby_parser_3_12_0 branch Dec 10, 2018

Repository owner locked and limited conversation to collaborators Feb 4, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.