Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "user input" values in SQLi warnings #1297

Merged
merged 1 commit into from Jan 18, 2019

Conversation

Projects
None yet
1 participant
@presidentbeef
Copy link
Owner

presidentbeef commented Jan 2, 2019

While Brakeman ignores a number of innocuous methods called inside of SQL strings, it does not ignore those same methods when it looks to highlight the "dangerous" value in the generated warning.

This changes that.

@presidentbeef presidentbeef merged commit 868cb6f into master Jan 18, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (90% threshold)
Details
codeclimate/total-coverage 94% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@presidentbeef presidentbeef deleted the better_user_input_reporting_sqli branch Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.