Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-integer version numbers #1326

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
1 participant
@presidentbeef
Copy link
Owner

presidentbeef commented Mar 6, 2019

Compare non-integers as strings. Integers and non-integer strings are never equal.

Fixes #1305

@presidentbeef presidentbeef merged commit dd7a72c into master Mar 6, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (90% threshold)
Details
codeclimate/total-coverage 94% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@presidentbeef presidentbeef deleted the handle_non_integer_versions branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.