Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL injection checks for find_or_create_by and friends #1337

Merged
merged 1 commit into from Mar 28, 2019

Conversation

Projects
None yet
1 participant
@presidentbeef
Copy link
Owner

commented Mar 27, 2019

  • find_or_create_by
  • find_or_create_by!
  • find_or_initialize_by

All of these methods call find_by which we already know is a problem.

Add SQLi checks for find_or_*
* find_or_create_by
* find_or_create_by!
* find_or_initialize_by

@presidentbeef presidentbeef merged commit 1a095d8 into master Mar 28, 2019

10 checks passed

ci/circleci: default Your tests passed on CircleCI!
Details
ci/circleci: test-2-3 Your tests passed on CircleCI!
Details
ci/circleci: test-2-4 Your tests passed on CircleCI!
Details
ci/circleci: test-2-5 Your tests passed on CircleCI!
Details
ci/circleci: test-2-6 Your tests passed on CircleCI!
Details
ci/circleci: test-jruby Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (90% threshold)
Details
codeclimate/total-coverage 94% (0.0% change)
Details

@presidentbeef presidentbeef deleted the sqli_find_or_create_by branch Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.