Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert !! calls to boolean value #1345

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
1 participant
@presidentbeef
Copy link
Owner

commented Apr 10, 2019

Calls like

!!a

Will be converted to

(true or false)

to reflect that they are (almost always) a boolean value.

! is a method call so it can do whatever you want but let's assume that's highly unusual. Also, this change only handles the method call case. Not going to worry about old code at this point.

Fixes #1343

@presidentbeef presidentbeef merged commit 9b1b1d7 into master Apr 11, 2019

10 checks passed

ci/circleci: default Your tests passed on CircleCI!
Details
ci/circleci: test-2-3 Your tests passed on CircleCI!
Details
ci/circleci: test-2-4 Your tests passed on CircleCI!
Details
ci/circleci: test-2-5 Your tests passed on CircleCI!
Details
ci/circleci: test-2-6 Your tests passed on CircleCI!
Details
ci/circleci: test-jruby Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (90% threshold)
Details
codeclimate/total-coverage 95% (0.0% change)
Details

@presidentbeef presidentbeef deleted the not_boolean branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.