Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle empty partial name #1352

Merged
merged 1 commit into from May 4, 2019

Conversation

Projects
None yet
1 participant
@presidentbeef
Copy link
Owner

commented May 4, 2019

Funny, there already was a guard for the partial name being an empty string but it was expecting a string literal and not an s-expression. That code was apparently from initial public commit of Brakeman...

Fixes #1350

Properly handle empty partial name
Fixes #1350

Funny there was a check for empty string but it was expecting a string
literal and not an s-expression. That code was from initial public
commit of Brakeman...

@presidentbeef presidentbeef merged commit ddd75d5 into master May 4, 2019

10 checks passed

ci/circleci: default Your tests passed on CircleCI!
Details
ci/circleci: test-2-3 Your tests passed on CircleCI!
Details
ci/circleci: test-2-4 Your tests passed on CircleCI!
Details
ci/circleci: test-2-5 Your tests passed on CircleCI!
Details
ci/circleci: test-2-6 Your tests passed on CircleCI!
Details
ci/circleci: test-jruby Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (90% threshold)
Details
codeclimate/total-coverage 95% (0.0% change)
Details

@presidentbeef presidentbeef deleted the fix_empty_partial_name branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.