Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brakeman::FilePath #1354

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
1 participant
@presidentbeef
Copy link
Owner

commented May 6, 2019

and stop using strings to represent file paths.

Cleaned up a lot of code as a result.

Changed uses of @file_name in processors to @current_file for accuracy and consistency.

Also removes collapse_mass_assignment option which hopefully no one was using, because it broke the assumption of "one warning = one file".

This addresses and supersedes #1351

Add Brakeman::FilePath
and stop using strings to represent file paths.

@presidentbeef presidentbeef merged commit 2314afb into master May 7, 2019

9 of 10 checks passed

codeclimate 2 issues to fix
Details
ci/circleci: default Your tests passed on CircleCI!
Details
ci/circleci: test-2-3 Your tests passed on CircleCI!
Details
ci/circleci: test-2-4 Your tests passed on CircleCI!
Details
ci/circleci: test-2-5 Your tests passed on CircleCI!
Details
ci/circleci: test-2-6 Your tests passed on CircleCI!
Details
ci/circleci: test-jruby Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
codeclimate/diff-coverage 98% (90% threshold)
Details
codeclimate/total-coverage 95% (0.0% change)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.