Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid assigning nil line numbers to Sexps #1360

Merged
merged 1 commit into from Jun 5, 2019

Conversation

@presidentbeef
Copy link
Owner

commented Jun 5, 2019

Since that raises an error in latest SexpProcessor.

Avoid assigning nil line numbers to Sexps
Since that raises an error in latest SexpProcessor.
@presidentbeef

This comment has been minimized.

Copy link
Owner Author

commented Jun 5, 2019

Test coverage coming in another PR, because problems were uncovered 😂

@presidentbeef presidentbeef merged commit 3b0017f into master Jun 5, 2019

9 of 10 checks passed

codeclimate/diff-coverage 62% (98% threshold)
Details
ci/circleci: default Your tests passed on CircleCI!
Details
ci/circleci: test-2-3 Your tests passed on CircleCI!
Details
ci/circleci: test-2-4 Your tests passed on CircleCI!
Details
ci/circleci: test-2-5 Your tests passed on CircleCI!
Details
ci/circleci: test-2-6 Your tests passed on CircleCI!
Details
ci/circleci: test-jruby Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/total-coverage 95% (0.0% change)
Details

@presidentbeef presidentbeef deleted the get_rid_of_nil_lines branch Jun 5, 2019

args.insert(1, Sexp.new(:lit, filter_name))
before_filter_call = make_call(nil, :before_filter, args)
args.insert(1, Sexp.new(:lit, filter_name).line(exp.line))
before_filter_call = make_call(nil, :before_filter, args).line(exp.line)

This comment has been minimized.

Copy link
@zenspider

zenspider Jul 13, 2019

These failed on my non-nil change?

This comment has been minimized.

Copy link
@presidentbeef

presidentbeef Jul 13, 2019

Author Owner

This may have been general cleanup to ensure Sexps have line numbers to prevent problems later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.