Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of template output in branches #1361

Merged
merged 1 commit into from Jun 6, 2019

Conversation

@presidentbeef
Copy link
Owner

commented Jun 5, 2019

This was not generating an XSS warning:

<%= blah ? x : params[:x].html_safe %>

Now each branch in an if expression will be its own "output" and handled separately.

@presidentbeef presidentbeef merged commit 6f70755 into master Jun 6, 2019

10 checks passed

ci/circleci: default Your tests passed on CircleCI!
Details
ci/circleci: test-2-3 Your tests passed on CircleCI!
Details
ci/circleci: test-2-4 Your tests passed on CircleCI!
Details
ci/circleci: test-2-5 Your tests passed on CircleCI!
Details
ci/circleci: test-2-6 Your tests passed on CircleCI!
Details
ci/circleci: test-jruby Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (98% threshold)
Details
codeclimate/total-coverage 95% (0.0% change)
Details

@presidentbeef presidentbeef deleted the better_handle_or_output branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.