Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip calls to `dup` #1386

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@presidentbeef
Copy link
Owner

commented Jul 22, 2019

as if they aren't even there.

Fixes #1374

In the future, it would be nice to be able to do this globally without rewriting the AST, but this is how it's been done in the past.

Skip calls to `dup`
as if they aren't even there.

Fixes #1374

@presidentbeef presidentbeef force-pushed the ignore_dup_calls branch from ee4a533 to 577c243 Jul 22, 2019

@presidentbeef presidentbeef merged commit 7260b56 into master Jul 22, 2019

9 checks passed

ci/circleci: default Your tests passed on CircleCI!
Details
ci/circleci: test-2-3 Your tests passed on CircleCI!
Details
ci/circleci: test-2-4 Your tests passed on CircleCI!
Details
ci/circleci: test-2-5 Your tests passed on CircleCI!
Details
ci/circleci: test-2-6 Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (98% threshold)
Details
codeclimate/total-coverage 95% (0.0% change)
Details

@presidentbeef presidentbeef deleted the ignore_dup_calls branch Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.