Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception in CheckCookieSerialization #1391

Merged
merged 2 commits into from Aug 13, 2019

Conversation

@philipturnbull
Copy link
Contributor

philipturnbull commented Aug 8, 2019

The and/or precedence rules cause us to execute setting.value == :hybrid
even when setting is not a symbol, which raises an exception:

Sexp#value called on multi-item Sexp: `s(:colon2, s(:const, :Custom), :Serializer)`
This fails with an exception:

```
Sexp#value called on multi-item Sexp: `s(:colon2, s(:const, :Custom), :Serializer)`
```
The `and`/`or` precedence rules cause us to execute `setting.value == :hybrid`
even when `setting` is not a symbol, which raises an exception:

```
Sexp#value called on multi-item Sexp: `s(:colon2, s(:const, :Custom), :Serializer)`
```
@presidentbeef presidentbeef merged commit 4e661d9 into presidentbeef:master Aug 13, 2019
9 checks passed
9 checks passed
ci/circleci: default Your tests passed on CircleCI!
Details
ci/circleci: test-2-3 Your tests passed on CircleCI!
Details
ci/circleci: test-2-4 Your tests passed on CircleCI!
Details
ci/circleci: test-2-5 Your tests passed on CircleCI!
Details
ci/circleci: test-2-6 Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (98% threshold)
Details
codeclimate/total-coverage 95% (0.0% change)
Details
@presidentbeef

This comment has been minimized.

Copy link
Owner

presidentbeef commented Aug 13, 2019

Thanks @philipturnbull! How embarrassing 😅

Repository owner locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.