Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version_between? method #1405

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@aglushkov
Copy link
Contributor

aglushkov commented Oct 9, 2019

Fixes #1404

@aglushkov aglushkov force-pushed the aglushkov:master branch 2 times, most recently from d490bfb to 9695c6b Oct 9, 2019
@presidentbeef

This comment has been minimized.

Copy link
Owner

presidentbeef commented Oct 10, 2019

Thanks @aglushkov, this seems to be heading in the right direction! If you rebase onto master it should resolve two of the test failures.

The test_number_of_warnings failure is concerning, though. It suggests Brakeman is not correctly detecting the version of Rails being used.

@aglushkov aglushkov force-pushed the aglushkov:master branch from 9695c6b to 9eabb27 Oct 10, 2019
Fixes #1404

Tweak protect_from_forgery min version, it is is enabled by default from version 5.2.0.beta1
https://github.com/rails/rails/blob/v5.2.0.beta2/actionpack/CHANGELOG.md
@aglushkov aglushkov force-pushed the aglushkov:master branch from 9eabb27 to d5ef1f3 Oct 10, 2019
@aglushkov

This comment has been minimized.

Copy link
Contributor Author

aglushkov commented Oct 10, 2019

@presidentbeef thanks for help with broken tests, everything is fixed

Updated protect_from_forgery min version from 5.2.0 to 5.2.0.beta1 to fix test_number_of_warnings.
Rails changelogs shows it should be 5.2.0.beta1 https://github.com/rails/rails/blob/v5.2.0.beta2/actionpack/CHANGELOG.md

@presidentbeef presidentbeef merged commit 5633686 into presidentbeef:master Oct 15, 2019
9 checks passed
9 checks passed
ci/circleci: default Your tests passed on CircleCI!
Details
ci/circleci: test-2-3 Your tests passed on CircleCI!
Details
ci/circleci: test-2-4 Your tests passed on CircleCI!
Details
ci/circleci: test-2-5 Your tests passed on CircleCI!
Details
ci/circleci: test-2-6 Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (98% threshold)
Details
codeclimate/total-coverage 95% (0.0% change)
Details
@presidentbeef

This comment has been minimized.

Copy link
Owner

presidentbeef commented Oct 15, 2019

Thanks! 🚀

@cabello

This comment has been minimized.

Copy link

cabello commented Oct 15, 2019

@presidentbeef I understand you are on vacation, so please enjoy it, if possible would you mind sharing an ETA for this version to hit Rubygems?

The reason I ask is that I have a few dozen repos using it and if it goes to Rubygems the new version will be automatically updated, otherwise I have to put PRs for each repo pointing it to master branch.

Thanks for making such useful software, I appreciate it 🙏

@presidentbeef

This comment has been minimized.

Copy link
Owner

presidentbeef commented Oct 15, 2019

I will attempt to get a release out this week. It is overdue.

@presidentbeef

This comment has been minimized.

Copy link
Owner

presidentbeef commented Oct 16, 2019

@cabello

This comment has been minimized.

Copy link

cabello commented Oct 16, 2019

Thank you very much 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.