Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort text report output by file and line #1412

Merged
merged 1 commit into from Oct 21, 2019

Conversation

@JacobEvelyn
Copy link
Contributor

JacobEvelyn commented Oct 17, 2019

When Brakeman gives a lot of output, I find it can be really confusing to scroll through it and fix everything when its output is jumping between files seemingly at random. This is especially true where a new version of brakeman finds many new warnings, and the same warning occurs multiple times within the same file. Because Brakeman's output is not sorted by file/line, it appears as though Brakeman "missed" some warnings in the file until you scroll through its entire output.

This commit simply has Brakeman include filename and line number in its sorting so output containing lots of warnings appears more coherent.

@presidentbeef presidentbeef merged commit 428bad2 into presidentbeef:master Oct 21, 2019
9 checks passed
9 checks passed
ci/circleci: default Your tests passed on CircleCI!
Details
ci/circleci: test-2-3 Your tests passed on CircleCI!
Details
ci/circleci: test-2-4 Your tests passed on CircleCI!
Details
ci/circleci: test-2-5 Your tests passed on CircleCI!
Details
ci/circleci: test-2-6 Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (98% threshold)
Details
codeclimate/total-coverage 95% (0.0% change)
Details
@presidentbeef

This comment has been minimized.

Copy link
Owner

presidentbeef commented Oct 21, 2019

Yes, this makes sense to me.

Also keep in mind you can compare JSON reports with --compare.

@JacobEvelyn JacobEvelyn deleted the JacobEvelyn:filename-and-line branch Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.