Remove special Sexp nodes from HAML processor #149

Merged
merged 3 commits into from Sep 21, 2012

2 participants

@presidentbeef

Brakeman was generating invalid call Sexps with :_hamlout as the target for _hamlout.options and hamlout.buffer. However, these special Sexps were not really be handled in Brakeman anywhere, and there was no real reason to make special Sexps for them.

Brakeman was also creating Sexps with the :tag type, which was also not handled anywhere. If one of those nodes had made it to the OutputProcessor, it would certainly have caused problems.

It's possible some of this code was specific to older versions of HAML. This is old code that clearly expected use in the future that was never needed.

added some commits Sep 19, 2012
@presidentbeef No special Sexps for options/buffer calls in HAML
Brakeman was generating invalid call Sexps with `:_hamlout`
as the target for `_hamlout.options` and `hamlout.buffer`.
However, these special Sexps were not really be handled in Brakeman
anywhere, and there was no real reason to make special Sexps for them.
0750e9f
@presidentbeef Remove unsupported :tag node type
Surprised this never caused any errors
ef8ea3f
@presidentbeef Remove special cased OutputProcessor#process_call
There should never be the case where the target of a :call Sexp is a
symbol, it should always be either `nil` or a Sexp. Brakeman should not
be building invalid Sexps.
c0cedbd
@oreoshake

take your word for it 👍

@presidentbeef presidentbeef merged commit 59aaaab into master Sep 21, 2012

1 check passed

Details default The Travis build passed
@presidentbeef presidentbeef locked and limited conversation to collaborators Feb 16, 2016
@presidentbeef presidentbeef deleted the no_special_case_for_hamlout branch Jul 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.