New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "find by regex" CallIndex feature #189

Merged
merged 1 commit into from Nov 27, 2012

Conversation

Projects
None yet
2 participants
@presidentbeef
Owner

presidentbeef commented Nov 27, 2012

Being able to find methods and targets by regular expressions was nice but it's not being used now. Meanwhile, it adds pointless overhead to the call indexing process.

Also, we should ignore call targets that are Sexps, as all searches for targets use Symbols and hashing Sexps takes time.

Remove "find by regex" CallIndex feature
Being able to find methods and targets by regular expressions
was nice but it's not being used now. Meanwhile, it adds overhead
to the call indexing process.

Also, we should ignore call targets that are Sexps, as all searches
for targets use Symbols and hashing Sexps takes time.
@oreoshake

This comment has been minimized.

Show comment
Hide comment
@oreoshake

oreoshake Nov 27, 2012

Contributor

20% speed boost! 🚀

Contributor

oreoshake commented Nov 27, 2012

20% speed boost! 🚀

presidentbeef added a commit that referenced this pull request Nov 27, 2012

@presidentbeef presidentbeef merged commit 54cabde into master Nov 27, 2012

1 check passed

default The Travis build passed
Details

@presidentbeef presidentbeef deleted the remove_call_index_regex branch Feb 25, 2015

Repository owner locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.