Keep whitespace format in Warning#to_hash/#to_json #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
stop molesting code |
presidentbeef
added a commit
that referenced
this pull request
Nov 29, 2012
Keep whitespace format in Warning#to_hash/#to_json
Repository owner
locked and limited conversation to collaborators
Feb 16, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code formatting for warnings strips whitespace and newlines. This was because that's what Brakeman's reports needed. But since JSON is the main format used by external tools, it should just provide unmolested and syntactically legal formatted code.
This will break any tools relying on the exact code string.