Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rails 4 no warning for friendly model in redirect_to (friendly_id gem compatibility) #400

Merged
merged 1 commit into from Oct 16, 2013

Conversation

Projects
None yet
2 participants
@aj0strow
Copy link
Contributor

commented Oct 4, 2013

Fixes #399

Only Rails 4 app is affected. Model.friendly is treated like Model for determining if it is a model in redirect_to calls.

Pretty codebase, btw!

@presidentbeef

This comment has been minimized.

Copy link
Owner

commented Oct 8, 2013

Hi AJ,

Thanks for this! I will check it out more carefully when I'm back from vacation.

@aj0strow

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2013

for sure, definitely no rush. enjoy the vacation!

presidentbeef added a commit that referenced this pull request Oct 16, 2013

Merge pull request #400 from aj0strow/rails4-friendlyid
rails 4 no warning for friendly model in redirect_to (friendly_id gem compatibility)

@presidentbeef presidentbeef merged commit e8f2624 into presidentbeef:master Oct 16, 2013

1 check passed

default The Travis CI build passed
Details
@presidentbeef

This comment has been minimized.

Copy link
Owner

commented Oct 16, 2013

Thanks!

@aj0strow aj0strow deleted the aj0strow:rails4-friendlyid branch Oct 16, 2013

Repository owner locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.