Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid warning about Symbol DoS on safe params #564

Merged
merged 1 commit into from Oct 9, 2014

Conversation

Projects
None yet
1 participant
@presidentbeef
Copy link
Owner

commented Oct 8, 2014

This is the promised follow-up to #538 in order to ignore symbolizing of params[:controller] and params[:action].

I don't plan to make any further reductions to false positives of this kind. Instead, CheckSymbolDoS will be an optional check starting in Brakeman 3.0.

presidentbeef added a commit that referenced this pull request Oct 9, 2014

Merge pull request #564 from presidentbeef/moar_safe_params_to_symbols
Avoid warning about Symbol DoS on safe params

@presidentbeef presidentbeef merged commit c412837 into master Oct 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

Repository owner locked and limited conversation to collaborators Feb 16, 2016

@presidentbeef presidentbeef deleted the moar_safe_params_to_symbols branch Jul 22, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.