New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Correct Term "Cross-Site" #936

Merged
merged 1 commit into from Sep 18, 2017

Conversation

Projects
None yet
3 participants
@paultetreau

paultetreau commented Sep 7, 2016

Replaced all instances of "cross site" with the properly hyphenated "cross-site", preserving case.

@b264

This comment has been minimized.

Show comment
Hide comment
@b264

b264 commented Sep 7, 2016

:shipit:

@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Sep 12, 2016

Owner

Hi Paul,

Thank you for the suggestion. However, it is not possible to change all instances of the term without essentially breaking out external API. Perhaps this could be a part of Brakeman 4.0, but the change cannot be made before then.

Owner

presidentbeef commented Sep 12, 2016

Hi Paul,

Thank you for the suggestion. However, it is not possible to change all instances of the term without essentially breaking out external API. Perhaps this could be a part of Brakeman 4.0, but the change cannot be made before then.

@presidentbeef presidentbeef added the 4.0 label Sep 13, 2016

@presidentbeef presidentbeef merged commit 1c4538d into presidentbeef:master Sep 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Repository owner locked and limited conversation to collaborators Oct 18, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.