New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for the latest version with new option #974

Merged
merged 1 commit into from Dec 29, 2016

Conversation

Projects
None yet
3 participants
@tamgrosser
Contributor

tamgrosser commented Dec 14, 2016

wip @grosser

@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Dec 14, 2016

Owner

Hi,

Thank you for putting this together. I think it would be better to use the Gem interface though, in case of API changes: http://www.rubydoc.info/stdlib/rubygems/Gem.latest_version_for

Owner

presidentbeef commented Dec 14, 2016

Hi,

Thank you for putting this together. I think it would be better to use the Gem interface though, in case of API changes: http://www.rubydoc.info/stdlib/rubygems/Gem.latest_version_for

@grosser

This comment has been minimized.

Show comment
Hide comment
@grosser

grosser Dec 15, 2016

Contributor

update!
a few observations:

  • tests are in a weird folder and do not end in _test.rb ... makes finding/working with them hard
  • tests cannot run on their own ... makes testing in isolation hard
  • there are no tests for commandline option handling in bin/brakeman
Contributor

grosser commented Dec 15, 2016

update!
a few observations:

  • tests are in a weird folder and do not end in _test.rb ... makes finding/working with them hard
  • tests cannot run on their own ... makes testing in isolation hard
  • there are no tests for commandline option handling in bin/brakeman
@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Dec 15, 2016

Owner

Thanks, this looks good.

  • The tests are in test/tests/ and used to also have test_... in the name and I couldn't take the triple redundancy.
  • You can run individual tests with ruby test/test.rb --name ...
  • Yes, this is true and has come up before and someone said they'd contribute testing for it...
Owner

presidentbeef commented Dec 15, 2016

Thanks, this looks good.

  • The tests are in test/tests/ and used to also have test_... in the name and I couldn't take the triple redundancy.
  • You can run individual tests with ruby test/test.rb --name ...
  • Yes, this is true and has come up before and someone said they'd contribute testing for it...
@grosser

This comment has been minimized.

Show comment
Hide comment
@grosser

grosser Dec 15, 2016

Contributor

Anything needed for merge ?

Contributor

grosser commented Dec 15, 2016

Anything needed for merge ?

@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Dec 16, 2016

Owner

Seems to work fine.

A couple minor things:

  • This should have a specific exit code like the -z
  • The option should be up around -z not in the scanning options section
Owner

presidentbeef commented Dec 16, 2016

Seems to work fine.

A couple minor things:

  • This should have a specific exit code like the -z
  • The option should be up around -z not in the scanning options section
@grosser

This comment has been minimized.

Show comment
Hide comment
@grosser

grosser Dec 19, 2016

Contributor

updated, looks better ?

Contributor

grosser commented Dec 19, 2016

updated, looks better ?

@presidentbeef presidentbeef merged commit 3d93b06 into presidentbeef:master Dec 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Dec 29, 2016

Owner

Thanks!

Owner

presidentbeef commented Dec 29, 2016

Thanks!

@grosser grosser deleted the tamgrosser:latest branch Feb 4, 2017

Repository owner locked and limited conversation to collaborators May 16, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.