New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow failing on error with --exit-on-error #991

Merged
merged 1 commit into from Feb 10, 2017

Conversation

Projects
None yet
2 participants
@grosser
Contributor

grosser commented Feb 4, 2017

@presidentbeef

solves #910

tested it with samson and works as expected :)

  • does not fail without flag
  • fails with flag
  • does not fail with flag and no errors

added --no-exit-on-error in case failing on error gets to be the default on day ... not sure if 4.0 would be a good milestone for that ...

@presidentbeef presidentbeef merged commit 34b7ebe into presidentbeef:master Feb 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Feb 10, 2017

Owner

Thanks!

Owner

presidentbeef commented Feb 10, 2017

Thanks!

@grosser

This comment has been minimized.

Show comment
Hide comment
@grosser

grosser Feb 10, 2017

Contributor
Contributor

grosser commented Feb 10, 2017

Repository owner locked and limited conversation to collaborators May 18, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.