Permalink
Switch branches/tags
Nothing to show
Commits on Feb 3, 2012
  1. Merge pull request #1 from grahamc/master

    Clean up the ChargifyExceptions file. If it doesn't work or breaks things even more, blame @warmwaffles not me.
    Vid Luther committed Feb 3, 2012
Commits on Feb 2, 2012
  1. Remove a single trailing tab.

    Graham Christensen committed Feb 2, 2012
  2. Centralize HTTP Exception logic into one place

    Move the constructor out of two separate Exception classes into a single base
    exception.
    
    Redeclare the member variables from the PHP4 style of `var` to `public`.
    
    Idealy these would be protected with public accessor methods, but that is not
    within the scope of these changes and breaks BC.
    Graham Christensen committed Feb 2, 2012
  3. Rename the NotFound exception to ChargifyNotFound

    This exception was not properly name, and would cause fatal errors if the
    NotFound error was ever encountered.
    Graham Christensen committed Feb 2, 2012
  4. Remove PHP4 style constructors

    Naming the constructor after the class name is deprecated behavior. I renamed
    them to __constructor for clarity.
    Graham Christensen committed Feb 2, 2012
  5. Remove the unused ChargifyError Exception

    The ChargifyError Exception was defined, however was never referenced in the
    source code. The misleading nature of this class can cause issues when trying
    to extend or implement Chargiphy.
    Graham Christensen committed Feb 2, 2012
  6. Remove ChargifyException::__constructor overload

    Overloading the ChargifyException broke one case in ChargifyConnector.php
    which passed in the Previous exception via the optional third parameter.
    
    Additionally, while the custom exceptions implementing in ChargifyException
    reverse the $message, $code parameters to $http_code, $message - they properly
    passed the parameters in the $message, $code order. The ChargifyException
    also reversed the order (to compensate for the reversal) but it was unnecessary
    and duplicating the existing work. This caused, ultimately, the arguemnts to
    be passed into the base Exception constructor in the wrong order.
    Graham Christensen committed Feb 2, 2012
  7. Remove trailing whitespace issues

    * Removed trailing whitespace from files
    * Removed the trailing ?>, which are unnecessary, and can cause whitespace
      mishaps if a newline is accidentally added to the end of the file.
    Graham Christensen committed Feb 2, 2012
  8. exception handling switch for 5.3

    Vid Luther committed Feb 2, 2012
Commits on Jan 18, 2012
  1. changed the response for an invalid coupon from an exception to a sim…

    …ple false for now.
    Vid Luther committed Jan 18, 2012
  2. made changes to the coupon code stuff.. for now we can check if a giv…

    …en coupon code is a valid coupon code in chargify or not
    Vid Luther committed Jan 18, 2012
Commits on Dec 29, 2011
  1. removed extraneous echo statements I added, just so I could trace thr…

    …ough what was going on
    Vid Luther committed Dec 29, 2011
  2. formatting

    Vid Luther committed Dec 29, 2011
  3. added docs on how to use as a git submodule

    Vid Luther committed Dec 29, 2011
Commits on Dec 28, 2011
  1. base docs added on how to use and history

    Vid Luther committed Dec 28, 2011
  2. base docs added on how to use and history

    Vid Luther committed Dec 28, 2011
  3. first commit

    Vid Luther committed Dec 28, 2011