Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Social Media Breaks Mobile Layout #28

Closed
connerbw opened this issue Aug 15, 2017 · 6 comments

Comments

@connerbw
Copy link
Member

commented Aug 15, 2017

Prerequisites

Check the boxes below by changing them from [ ] to [x].

Description

When I enabled "Add buttons to cover page and each chapter so that readers may share links to your book through social media: Facebook, Twitter, Google+" the layout is broken on my Android (Moto E, Chrome)

Tested in Luther (and Asimov Color)

Steps to Reproduce

  1. Theme Options -> Web Options -> Enable Social Media
  2. Navigate to a page on an Android (or emulate in Chrome)

Expected behavior: [What you expected to happen]

without-social-media-buttons

Actual behavior: [What actually happened]

with-social-media-buttons

System Information

Using a private test book for tests: https://dactest.pressbooks.com/front-matter/introduction/

@greatislander greatislander modified the milestone: 1.9.3 Aug 16, 2017

greatislander added a commit that referenced this issue Aug 16, 2017

@greatislander greatislander assigned zwhnz and apurvaashok and unassigned zwhnz and apurvaashok Aug 16, 2017

@greatislander

This comment has been minimized.

Copy link
Collaborator

commented Aug 16, 2017

Done.

@greatislander greatislander modified the milestones: 1.9.3, 1.10 Aug 17, 2017

@connerbw

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2017

In Textopress:

With Social Buttons, without comments:
ok

With Social Buttons, with comments:
off

The second one is still a bit off.

@connerbw connerbw reopened this Aug 17, 2017

@greatislander

This comment has been minimized.

Copy link
Collaborator

commented Aug 18, 2017

I'm seeing this on Textopress right now:

screen shot 2017-08-18 at 10 01 12 am

screen shot 2017-08-18 at 10 01 45 am

Is it still not appearing properly for you, @connerbw?

@connerbw

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2017

@greatislander

If I drag and drop the edges of my browser to the smallest possible size it's fine.

The problem happens in device mode ( in Chrome, I do CTRL+SHIFT+J -> CTRL+SHIFT+M to activate it )

Hope this helps.

@greatislander

This comment has been minimized.

Copy link
Collaborator

commented Aug 18, 2017

Set max-width: 100vw; and it seems to be working for me now.

@connerbw

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2017

Works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.