ci: use wp-cli i18n command instead of pb-cli #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #81 +/- ##
=========================================
Coverage 82.68% 82.68%
Complexity 103 103
=========================================
Files 3 3
Lines 283 283
=========================================
Hits 234 234
Misses 49 49 Continue to review full report at Codecov.
|
greatislander
changed the title
…s-sso into feat/wp-i18n
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial resolution to https://github.com/pressbooks/private/issues/910. In addition to replacing the
wp pb make-potcommand withwp i18n make-pot, this PR also replaces theupdate-translations.ymlworkflow's use of gettext with thewp i18n make-mocommand, which does the same thing.I've commented out the step which autocommits changes. Instead, when these workflows run if they result in any changed files, they will open a PR. Devs can merge if it looks good. In future, you may wish to switch back to autocommit.