Handle symlinked directories #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Trellis systems, the uploads directory is a symlink, so we need to use realpath() to resolve the symlink to ensure that we get an accurate directory size.
dac514
suggested changes
Oct 11, 2018
inc/stats/namespace.php
Outdated
| @@ -492,7 +492,7 @@ function display_network_storage() { | |||
| } | |||
|
|
|||
| function calculate_network_storage() { | |||
| $path = wp_upload_dir()['basedir']; | |||
| $path = realpath( wp_upload_dir()['basedir'] ); | |||
| $storage = format_bytes( rtrim( str_replace( $path, '', `du -b -s $path` ) ) ); | |||
There was a problem hiding this comment.
$path can theoretically be false.
$path can theoretically be exploited (the command line version of https://xkcd.com/327/) it should be wrapped in escapeshellarg()
There was a problem hiding this comment.
Backticks = shell_exec, (aka exec, aka system, ...) I would prefer a function here so I don't have to squint as much.
dac514
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Trellis systems, the uploads directory is a symlink, so we need to use realpath() to resolve the symlink to ensure that we get an accurate directory size.