Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SCSS variables based on options in compiler #782

Closed
greatislander opened this issue Jun 6, 2017 · 0 comments

Comments

@greatislander
Copy link
Collaborator

commented Jun 6, 2017

Prerequisites

Description

The SCSS compiler we use, leafo/scssphp, includes a method for passing variables to the compiler. We could use this instead of building a big chunk of SCSS based on theme options…

Steps to Reproduce

Not applicable.

System Information

Pressbooks: 4.0.0-dev
WordPress: 4.7.5
PHP: 7.1

@greatislander greatislander added this to the 4.0 milestone Jun 6, 2017

@greatislander greatislander self-assigned this Jun 6, 2017

@greatislander greatislander modified the milestone: 4.0 Jun 19, 2017

@greatislander greatislander modified the milestone: 4.4 Sep 11, 2017

@greatislander greatislander removed their assignment Sep 18, 2017

connerbw added a commit that referenced this issue Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.