Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word count #842

Closed
greatislander opened this issue Jul 10, 2017 · 8 comments

Comments

@greatislander
Copy link
Collaborator

commented Jul 10, 2017

Prerequisites

Description

There should be a way to get a book's word count. Where and how one does this TBD, but we can start with the implementation of actually counting the words.

Steps to Reproduce

Not applicable.

System Information

Pressbooks: 4.0.0-RC1
WordPress: 4.8.0
PHP: 7.1

@zwhnz

This comment has been minimized.

Copy link

commented Jul 12, 2017

Proposed interface handling:

  1. Display at end of chapter: “Word Count: 250 (chapter) / 1,250 (total)” (Using existing WP chapter counter - is this possible?)
    NOTE: total above is ... all content.
  2. Organize Page, top right next to ‘Global Privacy’ box (see below)
    a. Word count (all content): XXX
    b. Word count (selected for export): YYY

screen shot 2017-07-12 at 4 36 57 pm

@greatislander

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 12, 2017

@zwhpressbooks Looks great!

@hughmcguire

This comment has been minimized.

Copy link
Member

commented Jul 24, 2017

@greatislander all ok now, OK for priority list.

@greatislander greatislander modified the milestones: 4.1, 4.2 Jul 26, 2017

@connerbw

This comment has been minimized.

Copy link
Member

commented Jul 31, 2017

(Using existing WP chapter counter - is this possible?)

Not possible for now.

@connerbw

This comment has been minimized.

Copy link
Member

commented Jul 31, 2017

@connerbw connerbw assigned greatislander and unassigned connerbw Jul 31, 2017

@greatislander greatislander modified the milestones: 4.1, 4.2 Aug 1, 2017

@connerbw

This comment has been minimized.

Copy link
Member

commented Aug 2, 2017

-- 1.

On a book with a lot of words it starts off like this:

Word Count: 743848 (whole book) / 729728 (selected for export) (edited)

Then when I click an export checkmark:

Word Count: 743848 (whole book) / 729,701 (selected for export)

Notice the comma.

-- 2.

With large word counts, when I start it does add/subtract from the current count so the animation looks sharp, but if I click 3 or 4 times. It starts doing the animation from zero so it's a bit weird.

Probably related to the comma.

-- 3.

If you click the export <TH>, ajax calls occur as many times as there are rows, but because JS async there's no guarantee it's in order so the count can be off.

Maybe not worth the extra effort.

@greatislander

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 16, 2017

@connerbw made some improvements in #880.

@zwhnz

This comment has been minimized.

Copy link

commented Aug 16, 2017

Good to go from my end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.