Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete book feature #845

Closed
greatislander opened this issue Jul 12, 2017 · 5 comments

Comments

@greatislander
Copy link
Collaborator

commented Jul 12, 2017

Prerequisites

Description

Administrators of a book should be able to delete it.

To discuss: books should be set to deleted status for 30 days in case of regrets, then automatically deleted (via WP cron?).

Steps to Reproduce

  1. Click Book TitleDelete Book:

screen shot 2017-07-12 at 11 27 33 am

  1. Enter the title of the book on the interstitial page, then click to confirm deletion.

Expected behavior: Book status is changed to deleted. After 30 days, book tables are dropped from the database and book uploads directory is erased.

System Information

Pressbooks: 4.0
WordPress 4.8
PHP 7.1

@greatislander greatislander added this to the 4.2 milestone Jul 12, 2017

@greatislander greatislander referenced this issue Jul 12, 2017
4 of 4 tasks complete
@zwhnz

This comment has been minimized.

Copy link

commented Jul 12, 2017

Have discussed the 30 day window and agree that it's the best way to handle potential regrets.

The problem of books with multiple admins also came up, and we would propose that in an instance where someone tries to delete a book with multiple admins, they receive an error message directing them to contact support@pressbooks.com for pb.com or their network manager on other networks so this can be handled manually. Thoughts?

@greatislander

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 12, 2017

Makes sense to me.

@hughmcguire

This comment has been minimized.

Copy link
Member

commented Jul 24, 2017

this is OK to go @greatislander .... over to priority list.

@greatislander greatislander assigned connerbw and unassigned greatislander and zwhnz Jul 24, 2017

@greatislander greatislander modified the milestones: 4.2, 4.1 Jul 25, 2017

@connerbw

This comment has been minimized.

Copy link
Member

commented Jul 25, 2017

It turns out we disabled an existing WP feature.

Instead of re-inventing the wheel, let's tweak ms-delete-site.php

@apurvaashok

This comment has been minimized.

Copy link

commented Jul 26, 2017

Tested, and good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.