Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB Latex settings should only appear in books, not root site #910

Closed
greatislander opened this issue Aug 30, 2017 · 1 comment

Comments

@greatislander
Copy link
Collaborator

commented Aug 30, 2017

Prerequisites

Description

/symbionts/pb-latex/ should only register its admin settings page if we are on the dashboard of a book.

Steps to Reproduce

  1. Activate a generic theme (e.g. Twenty Seventeen) for your root site.
  2. Visit the dashboard.

Expected behavior: Only standard settings pages are visible in the settings menu.

Actual behavior: PB Latex appears in the settings menu.

System Information

Pressbooks: 4.1
WordPress: 4.8.1
PHP: 7.1

@greatislander greatislander added this to the 4.2 milestone Aug 30, 2017

connerbw added a commit that referenced this issue Aug 30, 2017

@connerbw connerbw assigned greatislander and unassigned connerbw Aug 30, 2017

@zwhnz

This comment has been minimized.

Copy link

commented Sep 1, 2017

A-ok so far as I can see!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.