HTMLBook Prototype #1032
Merged
HTMLBook Prototype #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1032 +/- ##
============================================
+ Coverage 48.31% 49.54% +1.22%
- Complexity 3151 3354 +203
============================================
Files 85 86 +1
Lines 14036 14755 +719
============================================
+ Hits 6782 7310 +528
- Misses 7254 7445 +191 |
greatislander
approved these changes
Jan 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of our XHTML exporter.
I tried to make it validate as best I could but even the most basic HTML fails. (Example:
[caption id="attachment_1" align="aligncenter" width="225"]<img class="wp-image-1 size-full" src="some-file.png" alt="Open Book" width="225" height="161" /> Like an open book.[/caption]will convert to invalid HTMLBook.)I think it's worth merging just to have something to test.