New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild Export Page (fixes #1525) #1553

Merged
merged 28 commits into from Jan 22, 2019

Conversation

2 participants
@connerbw
Copy link
Member

connerbw commented Jan 15, 2019

No description provided.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #1553 into dev will increase coverage by 0.65%.
The diff coverage is 76.03%.

@@             Coverage Diff              @@
##                dev    #1553      +/-   ##
============================================
+ Coverage     63.33%   63.98%   +0.65%     
- Complexity     4372     4437      +65     
============================================
  Files           114      116       +2     
  Lines         19077    19380     +303     
============================================
+ Hits          12082    12400     +318     
+ Misses         6995     6980      -15

@greatislander greatislander self-requested a review Jan 16, 2019

@greatislander greatislander self-assigned this Jan 16, 2019

@greatislander greatislander added this to the 5.7.0 milestone Jan 16, 2019

@greatislander greatislander added this to In progress in Pressbooks 5.7.0 via automation Jan 16, 2019

connerbw added some commits Jan 17, 2019

@greatislander
Copy link
Member

greatislander left a comment

Made some suggestions, mostly around accessibility features, labels etc. Once these are resolved we can merge and continue QA/review. Thanks @connerbw!

Show resolved Hide resolved inc/modules/export/class-table.php Outdated
Show resolved Hide resolved inc/modules/export/class-table.php
Show resolved Hide resolved inc/modules/export/class-table.php Outdated
Show resolved Hide resolved inc/modules/export/namespace.php Outdated
Show resolved Hide resolved inc/modules/export/class-table.php
Show resolved Hide resolved inc/modules/export/class-table.php
Show resolved Hide resolved assets/src/scripts/export.js

Pressbooks 5.7.0 automation moved this from In progress to Needs review Jan 18, 2019

Pressbooks 5.7.0 automation moved this from Needs review to Reviewer approved Jan 22, 2019

@greatislander greatislander force-pushed the rebuild-export-page branch from d889a9c to 1fab9eb Jan 22, 2019

Various polish
- Set pin status announcement to screen-reader-only
- Standardize collapsible panel UI, add title
- Improve responsiveness of panel contents
- Fix since version for file type label function

@greatislander greatislander force-pushed the rebuild-export-page branch from 1fab9eb to dc06711 Jan 22, 2019

greatislander and others added some commits Jan 22, 2019

@greatislander greatislander merged commit 7c92015 into dev Jan 22, 2019

3 checks passed

codecov/patch 76.03% of diff hit (target 63.33%)
Details
codecov/project 63.98% (+0.65%) compared to ce241fc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Pressbooks 5.7.0 automation moved this from Reviewer approved to Done Jan 22, 2019

@greatislander greatislander deleted the rebuild-export-page branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment