Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRebuild Export Page (fixes #1525) #1553
Conversation
connerbw
added some commits
Jan 9, 2019
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Jan 15, 2019
•
Codecov Report
@@ Coverage Diff @@
## dev #1553 +/- ##
============================================
+ Coverage 63.33% 63.98% +0.65%
- Complexity 4372 4437 +65
============================================
Files 114 116 +2
Lines 19077 19380 +303
============================================
+ Hits 12082 12400 +318
+ Misses 6995 6980 -15 |
greatislander
self-requested a review
Jan 16, 2019
greatislander
self-assigned this
Jan 16, 2019
greatislander
added
the
enhancement
label
Jan 16, 2019
greatislander
added this to the 5.7.0 milestone
Jan 16, 2019
greatislander
added this to In progress
in Pressbooks 5.7.0
via automation
Jan 16, 2019
connerbw
added some commits
Jan 17, 2019
greatislander
requested changes
Jan 18, 2019
|
Made some suggestions, mostly around accessibility features, labels etc. Once these are resolved we can merge and continue QA/review. Thanks @connerbw! |
Pressbooks 5.7.0
automation
moved this from In progress
to Needs review
Jan 18, 2019
greatislander
assigned
connerbw and
greatislander
and unassigned
greatislander
Jan 18, 2019
Pressbooks 5.7.0
automation
moved this from Needs review
to Reviewer approved
Jan 22, 2019
greatislander
approved these changes
Jan 22, 2019
greatislander
force-pushed the
rebuild-export-page
branch
from
d889a9c
to
1fab9eb
Jan 22, 2019
greatislander
force-pushed the
rebuild-export-page
branch
from
1fab9eb
to
dc06711
Jan 22, 2019
greatislander
and others
added some commits
Jan 22, 2019
greatislander
merged commit 7c92015
into
dev
Jan 22, 2019
Pressbooks 5.7.0
automation
moved this from Reviewer approved
to Done
Jan 22, 2019
greatislander
deleted the
rebuild-export-page
branch
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
connerbw commentedJan 15, 2019
No description provided.