New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve glossary terms and tooltips with rich text support (fix #1526) #1559

Merged
merged 11 commits into from Jan 22, 2019

Conversation

3 participants
@greatislander
Copy link
Member

greatislander commented Jan 17, 2019

Also fixes pressbooks/ideas#91, fixes pressbooks/ideas#152, fixes #1546.

  • Allow bold, italic, hyperlinks, line breaks, and paragraphs in glossary term content
  • Support rich text in tooltip output
  • Ensure tooltips stay attached to glossary terms (#1546)
  • When building list of glossary term definitions for tooltip display, do not create duplicate entries
  • Use dotted underlines for glossary term links in webbook (pressbooks/ideas#152)
  • Do not output list of glossary term definitions for tooltip display in exports
  • Tests, coverage

@greatislander greatislander added this to the 5.7.0 milestone Jan 17, 2019

@greatislander greatislander self-assigned this Jan 17, 2019

@greatislander greatislander added this to In progress in Pressbooks 5.7.0 via automation Jan 17, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #1559 into dev will decrease coverage by 0.63%.
The diff coverage is 82.5%.

@@             Coverage Diff              @@
##                dev    #1559      +/-   ##
============================================
- Coverage     64.02%   63.38%   -0.64%     
+ Complexity     4439     4378      -61     
============================================
  Files           116      114       -2     
  Lines         19385    19093     -292     
============================================
- Hits          12411    12102     -309     
- Misses         6974     6991      +17

@greatislander greatislander requested a review from connerbw Jan 18, 2019

Pressbooks 5.7.0 automation moved this from In progress to Needs review Jan 18, 2019

Show resolved Hide resolved tests/test-shortcodes-glossary.php Outdated
Show resolved Hide resolved tests/test-shortcodes-glossary.php Outdated

@greatislander greatislander removed the request for review from connerbw Jan 22, 2019

@greatislander greatislander merged commit f5e9492 into dev Jan 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Pressbooks 5.7.0 automation moved this from Needs review to Done Jan 22, 2019

@greatislander greatislander deleted the richtext-glossary branch Jan 22, 2019

@SteelWagstaff

This comment has been minimized.

Copy link

SteelWagstaff commented Jan 23, 2019

This looks great, Ned. I know that we had some users who were interested in including images in glossary entries -- this doesn't appear to be part of this improvement (possibly bc of shortcodes w/in shortcodes?), but is it something for future consideration or will it be out of bounds in the near term?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment