Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes running content #675

Merged
merged 6 commits into from Mar 9, 2017

Conversation

@hughmcguire
Copy link
Member

commented Feb 28, 2017

Ned this is the rework of the themes running content & numbering, so that we have one generic file to rule all page structures/running content/number positioning ... and can modify where we want numbers & content, using simple variables. (could be extended later to be user options, but no need now).

I suspect its far more verbose than it needs to be, but on the other hand it appears to work.

NOTE: this includes a fix for Clarke as well ...
Leaving these in need of similar, I think:

  • Gerhard
  • Asimov?
  • anything else?
@codecov

This comment has been minimized.

Copy link

commented Feb 28, 2017

Codecov Report

Merging #675 into dev will increase coverage by 0.58%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #675      +/-   ##
============================================
+ Coverage     12.85%   13.43%   +0.58%     
+ Complexity     2486     2363     -123     
============================================
  Files            69       67       -2     
  Lines         12360    11832     -528     
============================================
+ Hits           1589     1590       +1     
+ Misses        10771    10242     -529

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b3046...1783012. Read the comment docs.

@hughmcguire

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2017

NOTE: this is a breaking change for "new" themes, so need to fix:
Rothbard, Gerhard & Asimov

@hughmcguire

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2017

So, this is ready to merge I think, with following updates made to themes:

  • Clarke: this pull request includes updates to Clarke to support it
  • Rothbard: there is a new commit to dev to support this
  • Asimov: there is a pull-request from asimov-running-content to fix (pull request goes into master)
  • Gerhard: v2 has been updated to support this; Gerhard v2 has not been merged into dev yet (I think).

@greatislander greatislander changed the base branch from dev to hotfix Mar 9, 2017

@greatislander greatislander merged commit eacd2ac into hotfix Mar 9, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 92b3046...1783012
Details
codecov/project 13.43% (+0.58%) compared to 92b3046
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@greatislander greatislander deleted the themes-running-content branch Mar 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.