Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asyncronous loading of scripts to increase speed of page load #681

Merged
merged 7 commits into from Mar 20, 2017

Conversation

@bdolor
Copy link
Contributor

commented Mar 3, 2017

seems hooking into script_loader_tag is the current way to add async loading to scripts:

References:
https://core.trac.wordpress.org/ticket/12009
https://webkit.org/blog/1395/running-scripts-in-webkit/
https://developers.google.com/speed/pagespeed/insights/

Recommendations by PageSpeed Insights:

image

This PR adds async to javascript files:

image

@codecov

This comment has been minimized.

Copy link

commented Mar 3, 2017

Codecov Report

Merging #681 into dev will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #681   +/-   ##
=========================================
  Coverage     13.44%   13.44%           
  Complexity     2363     2363           
=========================================
  Files            67       67           
  Lines         11830    11830           
=========================================
  Hits           1590     1590           
  Misses        10240    10240

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53a2a3e...26fc570. Read the comment docs.

@greatislander greatislander merged commit d517501 into pressbooks:dev Mar 20, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 53a2a3e...26fc570
Details
codecov/project 13.44% remains the same compared to 53a2a3e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@bdolor bdolor deleted the bdolor:async branch Jun 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.