Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor option field display functions (closes #648) #697

Merged
merged 5 commits into from Mar 28, 2017

Conversation

@greatislander
Copy link
Collaborator

commented Mar 28, 2017

Render methods in \Pressbooks\Options now use a single parameter, $args, which is an array of key-value pairs, rather than individual parameters for each argument. For example:

renderCheckbox(
	$id = null,
	$name = null,
	$option = null,
	$value = '',
	$description = null
);

…becomes:

renderCheckbox( $args = array (
	'id' => null,
	'name' => null,
	'option' => null,
	'value' => '',
	'description' => null,
) );

@greatislander greatislander added this to the 3.9.8 milestone Mar 28, 2017

@greatislander greatislander self-assigned this Mar 28, 2017

@greatislander greatislander merged commit 5a9d69a into dev Mar 28, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@greatislander greatislander deleted the options-fields branch Mar 28, 2017

@codecov

This comment has been minimized.

Copy link

commented Mar 28, 2017

Codecov Report

Merging #697 into dev will decrease coverage by 0.43%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##                dev     #697      +/-   ##
============================================
- Coverage     13.42%   12.99%   -0.44%     
- Complexity     2370     2389      +19     
============================================
  Files            67       67              
  Lines         11861    12254     +393     
============================================
  Hits           1592     1592              
- Misses        10269    10662     +393

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f922dd6...2e902a8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.