Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `network_home_url()` instead of `PATH_CURRENT_SITE` #734

Merged

Conversation

@jeremyfelt
Copy link
Contributor

commented Apr 25, 2017

There are several redirects and an anchor that use PATH_CURRENT_SITE to generate the URL. It's possible to configure multisite without this constant, at which point PHP errors are generated in these
areas.

This makes the shift to network_home_url(), which uses the domain and path of the current network and provides a filter for anyone wishing to customize.

There are several redirects and an anchor that use `PATH_CURRENT_SITE`
to generate the URL. It's possible to configure multisite without
this constant, at which point PHP errors are generated in these
areas.

This makes the shift to `network_home_url()`, which uses the domain
and path of the current network and provides a filter for anyone
wishing to customize.
@codecov

This comment has been minimized.

Copy link

commented Apr 25, 2017

Codecov Report

Merging #734 into dev will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##               dev    #734      +/-   ##
==========================================
+ Coverage     13.2%   13.2%   +<.01%     
  Complexity    2479    2479              
==========================================
  Files           69      69              
  Lines        12561   12576      +15     
==========================================
+ Hits          1659    1661       +2     
- Misses       10902   10915      +13
@greatislander

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2017

Thanks @jeremyfelt!

@greatislander greatislander merged commit 7cf6756 into pressbooks:dev Apr 25, 2017
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing e85fa2b...e592a00
Details
codecov/project 13.2% (+<.01%) compared to e85fa2b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!
@greatislander greatislander added the bug label Apr 25, 2017
@greatislander greatislander self-assigned this Apr 25, 2017
@greatislander greatislander added this to the 3.9.9 milestone Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.