Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle situations where pb_language is not set #738

Merged
merged 1 commit into from May 7, 2017

Conversation

Projects
None yet
2 participants
@greatislander
Copy link
Collaborator

commented May 4, 2017

This should fix #737.

@greatislander greatislander added the bug label May 4, 2017

@greatislander greatislander added this to the 3.9.9 milestone May 4, 2017

@greatislander greatislander self-assigned this May 4, 2017

@codecov

This comment has been minimized.

Copy link

commented May 4, 2017

Codecov Report

Merging #738 into dev will increase coverage by 0.02%.
The diff coverage is 38.46%.

@@             Coverage Diff              @@
##                dev     #738      +/-   ##
============================================
+ Coverage     13.16%   13.18%   +0.02%     
- Complexity     2479     2480       +1     
============================================
  Files            69       69              
  Lines         12616    12618       +2     
============================================
+ Hits           1661     1664       +3     
+ Misses        10955    10954       -1
@monkecheese

This comment has been minimized.

Copy link
Contributor

commented May 5, 2017

Tested locally and this seems to fix the bug. Nicely done!

@greatislander greatislander merged commit 8474e4f into dev May 7, 2017

4 checks passed

codecov/patch 38.46% of diff hit (target 13.16%)
Details
codecov/project 13.18% (+0.02%) compared to 9352caf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@greatislander greatislander deleted the issues/737 branch May 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.