Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use template for pb_private() function #755

Merged
merged 1 commit into from May 24, 2017

Conversation

Projects
None yet
2 participants
@stepmuel
Copy link
Contributor

commented May 23, 2017

This allows themes to overwrite the standard login prompt by providing their own private.php template.

Use template for pb_private() function
This allows themes to overwrite the standard login prompt by providing their own private.php template.

Use template for pb_private() function
This allows themes to overwrite the standard login prompt by providing their own private.php template.
@codecov

This comment has been minimized.

Copy link

commented May 23, 2017

Codecov Report

Merging #755 into dev will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #755   +/-   ##
=========================================
  Coverage     17.09%   17.09%           
  Complexity     2483     2483           
=========================================
  Files            69       69           
  Lines         12574    12574           
=========================================
  Hits           2150     2150           
  Misses        10424    10424
@greatislander

This comment has been minimized.

Copy link
Collaborator

commented May 23, 2017

@stepmuel I have no objection to merging this PR. However, you should be aware that we are about to completely rebuild the core book theme, so this will likely be deprecated fairly quickly.

@stepmuel

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2017

@greatislander as long as there will be a releases with this included, it will help me. It's the only reason I can't use official releases, and it makes updating my installation complicated and error prone.

Is there any more information about the book theme rebuild, like approximate schedule, a branch or a list of planned changes? I was about to migrate my theme to SCSS, but am now considering to wait.

@greatislander

This comment has been minimized.

Copy link
Collaborator

commented May 24, 2017

We will be working on the rebuild during June and July. More announcements will be forthcoming, but it will be an extensive visual refresh and will also focus on improving accessibility for readers on the web.

@greatislander greatislander merged commit b407d52 into pressbooks:dev May 24, 2017

4 checks passed

codecov/patch Coverage not affected when comparing af58866...978a2fb
Details
codecov/project 17.09% remains the same compared to af58866
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.