Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Human Made coding standards [WIP] #758

Merged
merged 28 commits into from May 30, 2017

Conversation

@greatislander
Copy link
Collaborator

commented May 25, 2017

Fixes #731, still in progress.

@greatislander greatislander added this to the 4.0 milestone May 25, 2017

@greatislander greatislander self-assigned this May 25, 2017

@codecov

This comment has been minimized.

Copy link

commented May 25, 2017

Codecov Report

Merging #758 into dev will increase coverage by 6.16%.
The diff coverage is 19.52%.

@@             Coverage Diff              @@
##                dev     #758      +/-   ##
============================================
+ Coverage     17.11%   23.28%   +6.16%     
- Complexity     2494     2574      +80     
============================================
  Files            69       70       +1     
  Lines         12611    12810     +199     
============================================
+ Hits           2159     2983     +824     
+ Misses        10452     9827     -625

@greatislander greatislander requested a review from connerbw May 25, 2017

greatislander and others added 2 commits May 25, 2017
<exclude-pattern>compatibility.php</exclude-pattern>
<exclude-pattern>functions.php</exclude-pattern>
<exclude-pattern>bower_components/</exclude-pattern>
<exclude-pattern>node_modules/</exclude-pattern>

This comment has been minimized.

Copy link
@connerbw

connerbw May 25, 2017

Member

Tabs not aligned.

Would be nice to fix so that our user get a good first impression.

connerbw added 13 commits May 25, 2017

@connerbw connerbw self-assigned this May 26, 2017

connerbw and others added 4 commits May 26, 2017
Merge branch 'dev' into hm
# Conflicts:
#	composer.lock
#	inc/admin/class-network-managers-list-table.php
#	inc/admin/metaboxes/namespace.php
#	inc/class-book.php
#	inc/class-metadata.php
#	inc/editor/namespace.php
#	inc/modules/export/class-export.php
#	inc/modules/export/epub/class-epub201.php
#	inc/modules/export/epub/class-epub3.php
#	inc/modules/export/xhtml/class-xhtml11.php
#	inc/modules/import/html/class-xhtml.php
#	inc/modules/import/ooxml/class-docx.php
#	inc/modules/import/wordpress/class-wxr.php
#	inc/modules/themeoptions/class-pdfoptions.php
#	inc/redirect/namespace.php
#	inc/utility/namespace.php

@greatislander greatislander merged commit 005dccf into dev May 30, 2017

3 checks passed

codecov/patch 19.52% of diff hit (target 17.11%)
Details
codecov/project 23.28% (+6.16%) compared to 62cba0e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@greatislander greatislander deleted the hm branch May 30, 2017

@crism

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2017

Travis claims this was tested against PHP 5.6, but… I can run the 3.9.9 release just fine, but HEAD has produced HM-related errors since introduced. Both the WP server and command-line give the error:

PHP Fatal error:  Call to undefined function HM\Autoloader\register_class_path() in .../wp-content/plugins/pressbooks/pressbooks.php on line 77
Fatal error: Call to undefined function HM\Autoloader\register_class_path() in .../wp-content/plugins/pressbooks/pressbooks.php on line 77

This is with PHP 5.6.30 and WP 4.7.5 and 4.8, no active plugins other than Pressbooks… don’t want to file a(nother) spurious bug report if this isn’t expected to work.

@greatislander

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 9, 2017

@crism There is an accompanying docs change: #779

@crism

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2017

Ah-hah! Thanks! There’s a bug in the doc, though… stand by. (-:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.