Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pressbooks/v2/toc endpoint (fix #774) #778

Merged
merged 12 commits into from Jun 6, 2017

Conversation

@connerbw
Copy link
Member

commented Jun 5, 2017

I didn't write a unit test yet because I want to get some feedback before locking down this format.

Please squash?

@connerbw connerbw changed the title Introduce pressbooks/v2/toc endpoint #774 Introduce pressbooks/v2/toc endpoint (fix #774) Jun 5, 2017

@codecov

This comment has been minimized.

Copy link

commented Jun 5, 2017

Codecov Report

Merging #778 into dev will increase coverage by 0.86%.
The diff coverage is 0.38%.

@@             Coverage Diff              @@
##                dev     #778      +/-   ##
============================================
+ Coverage     23.31%   24.17%   +0.86%     
- Complexity     2555     2581      +26     
============================================
  Files            71       72       +1     
  Lines         12642    12965     +323     
============================================
+ Hits           2947     3134     +187     
- Misses         9695     9831     +136

@connerbw connerbw requested a review from greatislander Jun 5, 2017

@greatislander
Copy link
Collaborator

left a comment

@connerbw One tiny change, then I'll merge.

},
'update_callback' => __NAMESPACE__ . '\update_part_id',
'schema' => [
'description' => __( 'Part id.', 'pressbooks' ),

This comment has been minimized.

Copy link
@greatislander

greatislander Jun 6, 2017

Collaborator

Nitpicky, but could you change id to ID here?

@greatislander greatislander merged commit 1e66efd into dev Jun 6, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@greatislander greatislander deleted the api-toc branch Jun 6, 2017

@connerbw connerbw referenced this pull request Jun 10, 2017
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.